[PATCH] D51633: [ASTImporter] Added error handling for AST import.

[Balázs Kéri via Phabricator via cfe-commits]

balazske added inline comments.


================
Comment at: lib/AST/ASTImporter.cpp:8197
 
-void ASTImporter::ImportDefinition(Decl *From) {
+Error ASTImporter::ImportDefinition_New(Decl *From) {
   Decl *To = Import(From);
----------------
a_sidorin wrote:
> ImportDefinitionOrError?
The intention was to make the `_New` name only temporary until only this new function is used therefore it is not a nice name (requires changes in LLDB). Then it should be renamed back to `ImportDefinition`. It is probably not needed to indicate in the name that the function can fail, it can be seen from the return value. (This will be the case with other `Import` functions later.)


Repository:
  rC Clang

https://reviews.llvm.org/D51633