[PATCH] D53404: [clangd] Set workspace root when initializing ClangdServer, disallow mutation.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 18 08:44:31 PDT 2018


sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.

Rename instance variable to WorkspaceRoot to match what we call it internally.

Add fixme to set it automatically. Don't do it yet, clients have assumptions
that the constructor won't access the FS.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53404

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  unittests/clangd/FindSymbolsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53404.170098.patch
Type: text/x-patch
Size: 5103 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181018/6643b915/attachment.bin>


More information about the cfe-commits mailing list