[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D52670#1268347, @aaron.ballman wrote:

> In https://reviews.llvm.org/D52670#1268170, @lebedev.ri wrote:
>
> > - Apply minor wording nits.
> > - For `cert-dcl16-c`, **only** consider `L`, `LL` suffixes, not **anything** else (not even `llu`).
>
>
> I'll find out about the DCL16-C recommendation, as I suspect the intent is to cover `lu` and `llu` but not `ul` and `ull`.


I agree, i've thought so too.

That will open an interesting question: in `lu`, `l` should be upper-case. What about `u`? We can't keep it as-is.
We will either consistently upper-case it, or consistently lower-case it.
I.e. given `[lL][uU]`, should we *always* produce `Lu`, or `LU`?

> I've pinged the authors

Thank you.

> and can hopefully get an answer quickly, but if not, I'm fine with fixing that after the patch goes in.

Thank you.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52670