[PATCH] D53374: [clangd] Names that are not spelled in source code are reserved.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 18 03:35:12 PDT 2018
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/Quality.cpp:181
if (SemaCCResult.Declaration) {
+ if (!isSpelledInSourceCode(SemaCCResult.Declaration))
+ ImplementationDetail = true;
----------------
We could consider putting this in a one-liner function in AST.h or so, in case we want to add more heuristics - so SymbolCollector and Quality remain consistent. Up to you.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53374
More information about the cfe-commits
mailing list