[PATCH] D53102: Support for the mno-tls-direct-seg-refs flag

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 17 22:50:11 PDT 2018


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with that one style comment fixed.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:1743
+  if (!Args.hasFlag(options::OPT_mtls_direct_seg_refs,
+      options::OPT_mno_tls_direct_seg_refs, true))
+    CmdArgs.push_back("-mno-tls-direct-seg-refs");
----------------
minor - I think this line should be lined up with the start of the arguments to hasFlags on the previous line.


https://reviews.llvm.org/D53102





More information about the cfe-commits mailing list