[PATCH] D53381: [clang-doc] Bringing bitcode tests in line

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 17 11:53:18 PDT 2018


leonardchan accepted this revision.
leonardchan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp:39-40
+    return writeInfo(*static_cast<FunctionInfo *>(I));
+  default:
+    return "";
+  }
----------------
Nit: The `dispatchInfoForWrite` function returns true on default and writeInfo would catch that assert. I assume just returning empty string is intended on this case?


https://reviews.llvm.org/D53381





More information about the cfe-commits mailing list