[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.
Shahms King via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 17 08:36:06 PDT 2018
shahms added a comment.
It's worth noting that `RecursiveASTVisitor` appears to think they are at least somewhat equivalent in that it will only visit one or the other and prefers `TypeSourceInfo`, if present, via `VisitTypeLoc`. The fact that the TSI lacks this information makes it pretty awkward to access both the recursively deduced type and the corresponding source location. It seems like the places that expect this information to be absent could be trivially updated to disregard it after this patch, but synthesizing this from the available AST is much more challenging.
Repository:
rC Clang
https://reviews.llvm.org/D52301
More information about the cfe-commits
mailing list