[PATCH] D53363: [clangd] Encode Line/Column as a 32-bits integer.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 17 06:30:42 PDT 2018


hokein updated this revision to Diff 170001.
hokein marked 3 inline comments as done.
hokein added a comment.

Address review comments:

- handle overflowed cases, and added tests
- add getter/setters for line/column and clear all call sides


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53363

Files:
  clangd/FindSymbols.cpp
  clangd/XRefs.cpp
  clangd/index/Index.cpp
  clangd/index/Index.h
  clangd/index/Serialization.cpp
  clangd/index/SymbolCollector.cpp
  clangd/index/YAMLSerialization.cpp
  unittests/clangd/FileIndexTests.cpp
  unittests/clangd/IndexTests.cpp
  unittests/clangd/SymbolCollectorTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53363.170001.patch
Type: text/x-patch
Size: 13099 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181017/a8fdfe43/attachment-0001.bin>


More information about the cfe-commits mailing list