[PATCH] D52973: Add type_info predefined decl

[Matt Asplund via Phabricator via cfe-commits]

mwasplund added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:1467-1470
+  // FIXME: The Modules TS does not specify how to handle inplicit types
+  // For now we will simply ignore the implicit global types
+  if (Old->isImplicit())
+    return false;
----------------
rsmith wrote:
> Rather than doing this, please change `ASTContext::buildImplicitRecord` to `setModuleOwnershipKind(Decl::ModuleOwnershipKind::Unowned)` on the created declaration.
That doesn't seem to work. The check still fails since the owning module is now null. I can fix that by ignoring decls that have no owner on the old version, but I am also running into issues where the cached linkage no longer matches up.


Repository:
  rC Clang

https://reviews.llvm.org/D52973