[PATCH] D53192: [clangd] Do not query index for new name completions.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 16 16:29:19 PDT 2018


ilya-biryukov added a comment.

A drive-by NIT ;-)



================
Comment at: clangd/CodeComplete.cpp:643
   case CodeCompletionContext::CCC_Recovery:
+  // TODO: Provide identifier based completions for the following two contexts:
+  case CodeCompletionContext::CCC_Name:
----------------
sammccall wrote:
> consider Recovery, NaturalLanguage there too? and maybe Other?
NIT: use FIXME to be consistent with the rest of clangd


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53192





More information about the cfe-commits mailing list