[PATCH] D52973: Add type_info predefined decl

Matt Asplund via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 16 12:46:35 PDT 2018


mwasplund added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:1464
   if (NewM == OldM)
     return false;
----------------
rsmith wrote:
> Somewhere up here we're calling `getOwningModule()` but should be calling `getOwningModuleForLinkage()`. (Please upload patches with full context as described at https://llvm.org/docs/Phabricator.html)
I am using the git mirror to work out of so I can commit incremental changes. However when I used the commands provided they were only showing my latest change, not the full diff from origin master. I will give it another try...


Repository:
  rC Clang

https://reviews.llvm.org/D52973





More information about the cfe-commits mailing list