[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
  <key>clang_version</key>
-<string>clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang 80e1678b9f598ca78bb3b71cf546a63414a37b11) (https://github.com/llvm-mirror/llvm 1ffbf26a1a0a190d69327af875a3337b74a2ce82)</string>
+<string>clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang ec097c9a35733c2c703e8ff03ea9b6ae345bf3f3) (https://github.com/llvm-mirror/llvm 1ffbf26a1a0a190d69327af875a3337b74a2ce82)</string>
  <key>diagnostics</key>
----------------
george.karpenkov wrote:
> Could we figure out how not to have hardcoded contributor-based strings there? Maybe have a python script generating those / doing a cleanup?
I'm just about to remove it, as I did for all the other [PlistMacroExpancion] patches.

But yea, a tool wouldn't hurt.


https://reviews.llvm.org/D52790