[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 16 11:32:36 PDT 2018


george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map<const IdentifierInfo *, ExpArgTokens> {
+public:
----------------
Please don't do this, inheritance from standard containers is a bad thing (tm)


https://reviews.llvm.org/D52795





More information about the cfe-commits mailing list