[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai marked 3 inline comments as done.
vsapsai added a comment.

In https://reviews.llvm.org/D50539#1241034, @bruno wrote:

> > - Current way of working with modules in VFS "root" is clunky and error-prone.
>
> Why?


Mostly because when you approach it in a straightforward way, you cannot read written modules because they aren't in VFS and "rootness" correctly prevents you from reading random files. You can add `-fdisable-module-hash` as I've done in the test but it has its own downsides when used not in a test but in a real project.

>> Also I don't like that VFSFromYamlDirIterImpl is similar to overlay iterator but doesn't share code. At the moment I think it's not worth it to rework those abstractions to make more code reusable. If you've noticed problems with those iterators before, maybe it makes sense to try to find a better approach.
> 
> Maybe add FIXMEs for it?

Good idea, added.


https://reviews.llvm.org/D50539