[PATCH] D53286: [clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.

[Sam McCall via Phabricator via cfe-commits]

sammccall updated this revision to Diff 169835.
sammccall marked 9 inline comments as done.
sammccall added a comment.

Addressed review comments.
Also inverted the sense of the boolean return from `onNotify` etc, was "should
exit" and is now "should continue", which I think is slightly clearer.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53286

Files:
  clangd/CMakeLists.txt
  clangd/ClangdLSPServer.cpp
  clangd/ClangdLSPServer.h
  clangd/JSONRPCDispatcher.cpp
  clangd/JSONRPCDispatcher.h
  clangd/JSONTransport.cpp
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/Transport.h
  clangd/tool/ClangdMain.cpp
  test/clangd/compile-commands-path-in-initialize.test
  test/clangd/compile-commands-path.test
  test/clangd/completion-snippets.test
  test/clangd/completion.test
  test/clangd/crash-non-added-files.test
  test/clangd/execute-command.test
  test/clangd/input-mirror.test
  test/clangd/signature-help.test
  test/clangd/textdocument-didchange-fail.test
  test/clangd/trace.test
  test/clangd/xrefs.test
  unittests/clangd/CMakeLists.txt
  unittests/clangd/JSONTransportTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53286.169835.patch
Type: text/x-patch
Size: 53464 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181016/db13cbc0/attachment-0001.bin>