[PATCH] D53299: [Fixed Point Arithmetic] Fix for clang-tools-extra warning
Bjorn Pettersson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 15 12:40:10 PDT 2018
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.
Just some inline nit:s about whitespace.
LGTM, apart from that!
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:63
InitType->getAs<ComplexType>()->getElementType());
+ case Type::STK_FixedPoint:
+ switch (InitType->getAs<BuiltinType>()->getKind()) {
----------------
nit: I'd add an extra line break before this line (just to follow the earlier style where it seems like cases are put in different groups in this switch).
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:65
+ switch (InitType->getAs<BuiltinType>()->getKind()) {
+ case BuiltinType::ShortAccum:
+ case BuiltinType::SatShortAccum:
----------------
Indents: I think case should be aligned with the switch.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53299
More information about the cfe-commits
mailing list