[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:185
     clang::clangd::LookupRequest Request;
-    Request.IDs = {*SID};
+    Request.IDs.insert(IDs.begin(), IDs.end());
     bool FoundSymbol = false;
----------------
hokein wrote:
> sammccall wrote:
> > (nit: why not just initialize in place above?)
> In fact, Request.IDs and IDs are different types, and DenseSet is missing such constructor :(
I meant, why does the local variable "IDs" exist at all? Why not just populate `Request.IDs` directly?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53019