[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:61
+  Request.Scopes.emplace_back();
+  std::tie(Request.Scopes.back(), Request.Query) =
+      clang::clangd::splitQualifiedName(QualifiedName);
----------------
sammccall wrote:
> Are you sure you want both `foo` to mean `::foo` only, rather than accept any scope and the user can type `::foo` for explicitly global scope?
Oops, this is not intended. "foo" and "::foo" are different.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:185
     clang::clangd::LookupRequest Request;
-    Request.IDs = {*SID};
+    Request.IDs.insert(IDs.begin(), IDs.end());
     bool FoundSymbol = false;
----------------
sammccall wrote:
> (nit: why not just initialize in place above?)
In fact, Request.IDs and IDs are different types, and DenseSet is missing such constructor :(


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53019