[PATCH] D53273: [clangd] Fix some references missing in dynamic index.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 15 02:04:28 PDT 2018


hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.

Previously, SymbolCollector postfilters all references at the end to
find all references of interesting symbols.
It was incorrect when indxing main AST where we don't see locations
of symbol declarations and definitions in the main AST (as those are in
preamble AST).

The fix is to do earily check during collecting references.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53273

Files:
  clangd/index/SymbolCollector.cpp
  unittests/clangd/FileIndexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53273.169660.patch
Type: text/x-patch
Size: 4417 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181015/f7ad1cad/attachment.bin>


More information about the cfe-commits mailing list