[PATCH] D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 12 21:39:51 PDT 2018
EricWF added inline comments.
================
Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp:121
// allocations.
+int numAllocs;
+
----------------
Why?
================
Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp:171
#ifndef TEST_HAS_NO_EXCEPTIONS
- {
+ if (numAllocs > 0) {
try
----------------
I'm not sure I understand this change either.
https://reviews.llvm.org/D50860
More information about the cfe-commits
mailing list