[PATCH] D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai created this revision.
vsapsai added a reviewer: bruno.
Herald added subscribers: dexonsmith, hiraditya.

'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual attribute value isn't used and it works as if it is
always `true`.

Common use case for VFS iteration is iterating through files in umbrella
directories for modules. Ability to detect if some VFS entries point to
non-existing files is nice but non-critical. Instead of adding back
support for `'ignore-non-existent-contents': false` I am removing the
attribute, because such scenario isn't used widely enough and stricter
checks don't provide enough value to justify the maintenance.

rdar://problem/45176119


https://reviews.llvm.org/D53228

Files:
  clang/lib/Frontend/ModuleDependencyCollector.cpp
  clang/test/Modules/crash-vfs-headermaps.m
  clang/test/Modules/crash-vfs-include-pch.m
  clang/test/Modules/crash-vfs-ivfsoverlay.m
  clang/test/Modules/crash-vfs-relative-incdir.m
  clang/test/Modules/crash-vfs-run-reproducer.m
  clang/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml
  clang/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
  clang/test/VFS/Inputs/bar-headers.yaml
  clang/test/VFS/Inputs/vfsoverlay2.yaml
  llvm/include/llvm/Support/VirtualFileSystem.h
  llvm/lib/Support/VirtualFileSystem.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53228.169520.patch
Type: text/x-patch
Size: 9342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181012/7da3e62f/attachment.bin>