[PATCH] D53195: [MinGW] Allow using LTO when lld is used as linker

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 12 11:42:01 PDT 2018


mstorsjo added inline comments.


================
Comment at: lib/Driver/ToolChains/MinGW.cpp:383
+      Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER)
+          .equals_lower("lld");
 }
----------------
rnk wrote:
> I thought we supported putting paths in this option, but I see we already use this pattern almost everywhere throughout the driver, so I guess checking for the symbolic name is fine.
Well, in ToolChain::GetLinkerPath(), we do support both an absolute path and a symbolic name, but yes, there are other checks for symbolic names as well. Not sure if we should try to guess the kind of linker from an absolute pathname though...


https://reviews.llvm.org/D53195





More information about the cfe-commits mailing list