[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 12 09:29:20 PDT 2018


mgorny created this revision.
mgorny added reviewers: sammccall, bkramer, aadg.
Herald added a subscriber: arphaman.

Remove the test checking for compilation db lookup failure.
Since r342228, JSONCompilationDatabasePlugin infers compile commands for
missing files, therefore making the lookup always succeed.


Repository:
  rC Clang

https://reviews.llvm.org/D53202

Files:
  bindings/python/tests/cindex/test_cdb.py


Index: bindings/python/tests/cindex/test_cdb.py
===================================================================
--- bindings/python/tests/cindex/test_cdb.py
+++ bindings/python/tests/cindex/test_cdb.py
@@ -31,11 +31,6 @@
         """Check we can load a compilation database"""
         cdb = CompilationDatabase.fromDirectory(kInputsDir)
 
-    def test_lookup_fail(self):
-        """Check file lookup failure"""
-        cdb = CompilationDatabase.fromDirectory(kInputsDir)
-        self.assertIsNone(cdb.getCompileCommands('file_do_not_exist.cpp'))
-
     def test_lookup_succeed(self):
         """Check we get some results if the file exists in the db"""
         cdb = CompilationDatabase.fromDirectory(kInputsDir)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53202.169427.patch
Type: text/x-patch
Size: 724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181012/a1c5f523/attachment-0001.bin>


More information about the cfe-commits mailing list