[PATCH] D53032: [clangd] Minimal implementation of automatic static index, behind a flag.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:14
+
+TEST(BackgroundIndexTest, IndexesOneFile) {
+  MockFSProvider FS;
----------------
sammccall wrote:
> ioeric wrote:
> > Also add a test for `enqueueAll` with multiple TUs ?
> Is it important to call `enqueueAll` specifically vs `enqueue` multiple times?
> 
> We don't have a good test fixture for a compilation database, and `enqueueAll` is trivial...
I think the randomization code worths a test. 

How about adding a test in ClangdServer with the auto index enabled? I think we'd also want coverage in ClangdServer anyway.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53032