[PATCH] D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri updated this revision to Diff 169401.
lebedev.ri marked 2 inline comments as done.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

Let's try to wrap this up.

- Dropped HICPP alias. I/we really don't understand what those guidelines require.
- Don't touch unions. https://github.com/isocpp/CppCoreGuidelines/issues/1281
- Deduplicate check lines, yay.
- Some code cleanups.

FIXME: `IgnoreClassesWithAllMemberVariablesBeingPublic` needs to be somehow enabled for cppcoreguidelines check.
I don't know if it is possible, and how.

Anything i missed?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52771

Files:
  clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/MiscTidyModule.cpp
  clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp
  clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/cppcoreguidelines-non-private-member-variables-in-classes.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst
  test/clang-tidy/misc-non-private-member-variables-in-classes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52771.169401.patch
Type: text/x-patch
Size: 23167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181012/475f2d8c/attachment-0001.bin>