[PATCH] D53187: [clang-tidy] Optimize query in bugprone-exception-escape

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 12 06:01:45 PDT 2018


baloghadamsoftware added a comment.

I think that with this optimization it is not so expensive anymore. I do not think it was an endless loop in the bugreport but it was insufferable execution time. Maybe we could speed it up a little more by changing it totally to a width-first CFG visitor. Then we could apply your solution as well (not removing visited function from the call stack) so the algorithm would visit every called function (for every function that should not throw) only once along the shortest path. This would not introduce new false positives neither would it lose true positives.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53187





More information about the cfe-commits mailing list