[PATCH] D53194: [clang-tidy] Fix check_clang_tidy.py trivially passing default CHECK

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 12 05:55:43 PDT 2018


JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.

Did you verify it actually works?
Otherwise LGTM and because its a bug-fix you can commit and other concerns can be done post-commit.



================
Comment at: test/clang-tidy/check_clang_tidy.py:129
+
+  assert has_check_fixes or has_check_messages or has_check_notes
   # Remove the contents of the CHECK lines to avoid CHECKs matching on
----------------
Nit: Could you please move this assert three lines up? It looks that its actually checking the conditions established there.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53194





More information about the cfe-commits mailing list