[PATCH] D53192: [clangd] Do not query index for new name completions.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 12 05:07:46 PDT 2018
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53192
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
===================================================================
--- unittests/clangd/CodeCompleteTests.cpp
+++ unittests/clangd/CodeCompleteTests.cpp
@@ -2154,6 +2154,15 @@
AllOf(Qualifier("nx::"), Named("Clangd2"))));
}
+TEST(CompletionTest, NoCompletionsForNewNames) {
+ clangd::CodeCompleteOptions Opts;
+ Opts.AllScopes = true;
+ auto Results = completions(R"cpp(
+ void f() { int n^ }
+ )cpp",
+ {cls("naber"), cls("nx::foo")}, Opts);
+ EXPECT_THAT(Results.Completions, UnorderedElementsAre());
+}
} // namespace
} // namespace clangd
} // namespace clang
Index: clangd/CodeComplete.cpp
===================================================================
--- clangd/CodeComplete.cpp
+++ clangd/CodeComplete.cpp
@@ -620,8 +620,6 @@
case CodeCompletionContext::CCC_ObjCProtocolName:
case CodeCompletionContext::CCC_Namespace:
case CodeCompletionContext::CCC_Type:
- case CodeCompletionContext::CCC_Name: // FIXME: why does ns::^ give this?
- case CodeCompletionContext::CCC_PotentiallyQualifiedName:
case CodeCompletionContext::CCC_ParenthesizedExpression:
case CodeCompletionContext::CCC_ObjCInterfaceName:
case CodeCompletionContext::CCC_ObjCCategoryName:
@@ -642,6 +640,9 @@
case CodeCompletionContext::CCC_ObjCClassMessage:
case CodeCompletionContext::CCC_IncludedFile:
case CodeCompletionContext::CCC_Recovery:
+ // TODO: Provide identifier based completions for the following two contexts:
+ case CodeCompletionContext::CCC_Name:
+ case CodeCompletionContext::CCC_PotentiallyQualifiedName:
return false;
}
llvm_unreachable("unknown code completion context");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53192.169373.patch
Type: text/x-patch
Size: 1743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181012/3c7eae7c/attachment.bin>
More information about the cfe-commits
mailing list