[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

[Kristof Beyls via Phabricator via cfe-commits]

kristof.beyls added inline comments.


================
Comment at: test/Driver/arm-mfpu.c:410
+
+// RUN: %clang -target armv7-linux-androideabi23 %s -mfpu=vfp3-d16 -### -c 2>&1 \
+// RUN:   | FileCheck --check-prefix=CHECK-ARM-ANDROID-M-FP-D16 %s
----------------
danalbert wrote:
> >>! In D53121#1261602, @kristof.beyls wrote:
> > Seems fine to me too. I'd maybe just add an additional test case to verify that things still work as expected when users explicitly specify that they want to target a different FPU (e.g. "-mfpu=none").
> 
> Is this test (and it's counterpart in `CHECK-ARM-ANDROID-L-FP-NEON`) not sufficient? It shows that `-mfpu` is honored regardless of the default. Is there something special about `-mfpu=none` that this doesn't exercise?
you're right - this test does what I was asking for. Apologies, I should've looked more closely - I hadn't picked up this mfpu isn't the default one...


Repository:
  rC Clang

https://reviews.llvm.org/D53121