[PATCH] D53154: [CodeGen] Handle extern references to OBJC_CLASS_$_*

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 11 11:22:22 PDT 2018


jfb added a comment.

Overall this seems fine, but I'm no ObjC expert either so I'll defer to @rjmccall



================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:7193
+  if (!GV || GV->getType() != ObjCTypes.ClassnfABITy->getPointerTo()) {
+    auto *NewGV = new llvm::GlobalVariable(ObjCTypes.ClassnfABITy, false, L,
+                                           nullptr, Name);
----------------
Add `/* isConstant=*/false`


Repository:
  rC Clang

https://reviews.llvm.org/D53154





More information about the cfe-commits mailing list