[PATCH] D53102: Support for the mno-tls-direct-seg-refs flag

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

Looking good, just a few minor comments.



================
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
----------------
This file is automatically generated based on the options .td files, so no need to update it here.


================
Comment at: include/clang/Driver/CC1Options.td:195
   HelpText<"Do not emit code that uses the red zone.">;
+def indirect_tls_seg_refs : Flag<["-"], "indirect-tls-seg-refs">,
+  HelpText<"Do not emit code that uses direct TLS segment access.">;
----------------
Could mno_tls_direct_seg_refs be used as a cc1 flag instead?


================
Comment at: include/clang/Driver/Options.td:2167
+def mtls_direct_seg_refs : Flag<["-"], "mtls-direct-seg-refs">, Group<m_Group>,
+  HelpText<"Enable direct TLS access through segment registers">;
 def mregparm_EQ : Joined<["-"], "mregparm=">, Group<m_Group>;
----------------
Maybe add (default) to the help text to indicate this is the default?


Repository:
  rC Clang

https://reviews.llvm.org/D53102