[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In https://reviews.llvm.org/D52311#1255876, @simark wrote:

> I just tried this, this looks very promising!  It should help build our outline view in a much more robust way than we do currently.
>  A nit for the final patch, I would suggest omitting the fields that are optional, like `children` (when the list is empty) and `deprecated`.


SG, will do.

> In vscode, is there a way to get a tree representation of this data?  When I look at "Go to symbol in File..." (ctrl-shift-o) or the outline view at the bottom of the file explorer, they are both a flat list.  What difference does this patch make in how vscode shows the data?

There's an outline view that shows the tree after this patch.
IIRC, the "Go to symbol in File..." also shows the tree view now without the lack of functionality like filtering by name, etc.
Overall, the experience with a tree seemed strictly better in all scenarios for me.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52311