[PATCH] D53131: [clangd] Support scope proximity in code completion.

[Eric Liu via Phabricator via cfe-commits]

ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.

This should make all-scope completion more usable. Scope proximity for
indexes will be added in followup patch.

Measurements showed a slight improvement on the overall completion quality
(with all-scope completion diabled).

    Total measurements: 110715 (+0)
    Average latency (ms): 278.558380127 (+47)
    All measurements:
  	MRR: 67.47 (+0.32)	Top-1: 57.68% (+0.27%)	Top-5: 79.92% (+0.46%)	Top-100: 94.57% (+0.39%)
    Full identifiers:
  	MRR: 97.85 (-0.01)	Top-1: 97.09% (-0.01%)	Top-5: 98.74% (-0.01%)	Top-100: 98.78% (-0.02%)
    Filter length 0-5:
  	MRR:      22.88 (+0.04)		55.86 (+0.64)		69.39 (+0.84)		73.53 (+0.34)		76.47 (+0.20)		80.76 (+0.17)
  	Top-1:    12.06% (-0.05%)		42.40% (+0.23%)		57.28% (+0.85%)		61.85% (+0.39%)		65.80% (+0.25%)		71.38% (+0.22%)
  	Top-5:    35.86% (-0.03%)		72.92% (+1.46%)		85.07% (+0.99%)		88.60% (+0.33%)		90.25% (+0.18%)		92.91% (+0.19%)
  	Top-100:  76.26% (+2.59%)		95.91% (+0.04%)		98.02% (-0.01%)		98.22% (-0.03%)		98.18% (-0.03%)		98.33% (-0.02%)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53131

Files:
  clangd/CodeComplete.cpp
  clangd/Quality.cpp
  clangd/Quality.h
  unittests/clangd/CodeCompleteTests.cpp
  unittests/clangd/QualityTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53131.169180.patch
Type: text/x-patch
Size: 16472 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181011/61945bed/attachment.bin>