[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 -Wno-unused %s
+
----------------
Rakete1111 wrote:
> lebedev.ri wrote:
> > One last-minute thought: this is only a positive test.
> > You don't test what happens before C++17.
> It is tested. Look at the diff for test/SemaCXX/warn-unsequenced.cpp :)
> Or are you suggesting to merge the two files?
I see that the negative test is in `warn-unsequenced.cpp`, but the positive test is in `warn-unsequenced-cxx17.cpp`.
This split is the reason of my remark.
I'm not sure if this is an issue, or if merging them is the solution.


https://reviews.llvm.org/D50766