[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:10874
+      if (Target->isSpecificBuiltinType(BuiltinType::LongDouble))
+        FloatSem = &llvm::APFloat::x87DoubleExtended();
+
----------------
efriedma wrote:
> ASTContext::getFloatTypeSemantics.  (Your explicit computation here is both redundant and wrong.)
Great tip! thanks. I overlooked it :/


https://reviews.llvm.org/D52835