[PATCH] D52857: Deprecate 'set output foo' API of clang-query

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

@steveire and I chatted over IRC and I wanted to capture another alternate proposal idea as part of the review (we did not reach agreement on this proposal, however). I've provided it side-by-side with the other proposals for comparison purposes.

  # Original proposal
  set dump-output true
  match foo(bar(baz())) # Uses one output format
  match bar(foo()) # Uses one output format
  set diag-output true
  set matcher-output true
  match foo(bar(baz())) # Uses all three output formats
  match bar(foo()) # Uses all three output formats
  set diag-output false
  set dump-output false
  match foo(bar(baz())) # Uses only matcher output
   
  # First Alternative
  set output dump
  match foo(bar(baz())) # Uses one output format
  match bar(foo()) # Uses one output format
  set output dump, diag, matcher
  match foo(bar(baz())) # Uses all three output formats
  match bar(foo()) # Uses all three output formats
  set output matcher
  match foo(bar(baz())) # Uses only matcher output
   
  # Second Alternative
  set output dump
  match foo(bar(baz())) # Uses one output format
  match bar(foo()) # Uses one output format
  set output diag toggle on
  set output matcher toggle on
  match foo(bar(baz())) # Uses all three output formats
  match bar(foo()) # Uses all three output formats
  set output matcher
  match foo(bar(baz())) # Uses only matcher output


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52857