[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected
Simon Atanasyan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 10 09:03:57 PDT 2018
atanasyan added a comment.
In https://reviews.llvm.org/D52418#1256189, @brad wrote:
> Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp?
Good point. In fact, integrated assembler for GNUABIN32 was enabled in the `MipsMCAsmInfo` ctor by me and by mistake. I have another patch which fix it. But anyway there is a problem - we cannot check command line options in the `MipsMCAsmInfo`. So I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to enable integrated assembler for it. In that case both `Generic_GCC::IsIntegratedAssemblerDefault()` and `MipsMCAsmInfo` ctor can be simplified.
Repository:
rC Clang
https://reviews.llvm.org/D52418
More information about the cfe-commits
mailing list