[PATCH] D51809: [CUDA][HIP] Fix ShouldDeleteSpecialMember for inherited constructors

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 9 08:25:29 PDT 2018


yaxunl added inline comments.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:7231
+    if (ICI)
+      CSM = getSpecialMember(MD);
+
----------------
jlebar wrote:
> LGTM, but perhaps we should use a new variable instead of modifying `CSM` in case someone adds code beneath this branch?
will do when committing.


https://reviews.llvm.org/D51809





More information about the cfe-commits mailing list