[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables
Sylvestre Ledru via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 9 01:21:59 PDT 2018
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: ecbeckmann.
Herald added a subscriber: mgorny.
When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set,
the developer can expect that the stage2 clang is built using the same mode.
Especially as the performances are much worst in debug mode.
(Principle of least astonishment)
Repository:
rC Clang
https://reviews.llvm.org/D53014
Files:
CMakeLists.txt
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -609,6 +609,7 @@
CLANG_REPOSITORY_STRING
CMAKE_MAKE_PROGRAM
CMAKE_OSX_ARCHITECTURES
+ CMAKE_BUILD_TYPE
LLVM_ENABLE_PROJECTS
LLVM_ENABLE_RUNTIMES)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53014.168755.patch
Type: text/x-patch
Size: 307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181009/e5565e25/attachment.bin>
More information about the cfe-commits
mailing list