[PATCH] D52984: [analyzer] Checker reviewer's checklist

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added a comment.

LGTM! I can think of a couple more, like

- making sure that `clang-format` was run on the new files,
- not forgetting header guards,
- making sure that variables and functions only intended for use within an `assert` call are handled in a way that release build bots won't break on them (`(void)Var`),
- every virtual overridden method is marked as `override` (bots love breaking on that),

but these are general rules, not specific to the analyzer, even if they are easily forgotten and aren't emphasized enough elsewhere.


https://reviews.llvm.org/D52984