[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

The change looks reasonable to me, so lg. I'd wait a bit to see whether other reviewers have comments.



================
Comment at: lib/Index/USRGeneration.cpp:339
+void USRGenerator::VisitBindingDecl(const BindingDecl *D) {
+  if (D->getParentFunctionOrMethod() && GenLoc(D, /*IncludeOffset=*/true))
+    return;
----------------
use `isLocal(D)` instead.


Repository:
  rC Clang

https://reviews.llvm.org/D52445