[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p
Bill Wendling via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 7 01:44:30 PDT 2018
void added a comment.
@rsmith I've been implementing your suggestion, but it's quickly becoming ridiculous. Just to implement a `ConstExpr` wrapper class, I need to touch ~23 files, virtually all changes being boilerplate code to forward the action to the wrapped expression. And this is before I add the code in this patch that implements the feature. While it would be nice to use LLVM's type system to determine if an expression is expected to be constant, it appears that doing that is much worse than adding the information to the bits field you mentioned.
Repository:
rC Clang
https://reviews.llvm.org/D52854
More information about the cfe-commits
mailing list