[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

[Anton Bikineev via Phabricator via cfe-commits]

AntonBikineev marked an inline comment as done.
AntonBikineev added a comment.

I've submitted an issue to the Core about the case. Presumably, it will be included in the next revision (mailing deadline of which is tomorrow).



================
Comment at: lib/CodeGen/CGCall.cpp:1893
+
+    IsCtor = isa<CXXConstructorDecl>(TargetDecl);
   }
----------------
rjmccall wrote:
> I feel like you should just use `TargetDecl && isa<CXXConstructorDecl>(TargetDecl)` below; it's more obvious.
> 
> Is there not an analogous rule for destructors?
There appears to be no similar rule for destructors, maybe because at the point of calling a destructor the value of the object/subobjects is well-determined.


Repository:
  rC Clang

https://reviews.llvm.org/D46441