[PATCH] D52750: [Diagnostics] Check for integer overflow in array size expressions

[Nicolas Lesser via Phabricator via cfe-commits]

Rakete1111 added inline comments.


================
Comment at: lib/Sema/SemaType.cpp:2232
+
+      if (isa<BinaryOperator>(ArraySize))
+        ArraySize->EvaluateForOverflow(Context);
----------------
What's up with this statement? Why is it needed? This won't handle overflows for unary expression for example.


https://reviews.llvm.org/D52750