[PATCH] D52920: Introduce code_model macros

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 17:56:03 PDT 2018


MaskRay added inline comments.


================
Comment at: lib/Basic/Targets/X86.cpp:865
+  if (CodeModel == "default")
+    // When the user has not explicitly specified anything,
+    // the default code model to use is small.
----------------
I'm not sure if the comment is useful here... or you can comment that this piece of code should be consistent with X86TargetMachine.cpp#L208


Repository:
  rC Clang

https://reviews.llvm.org/D52920





More information about the cfe-commits mailing list