[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 16:05:13 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D52398#1255290, @aaronpuchert wrote:

> @hokein Please have a look at https://reviews.llvm.org/D52888, maybe you can try it out already. The problem was that `?:` expressions are considered a branch point and when merging both branches the warning was emitted. Before this change, we couldn't look into `__builtin_expect` and so we didn't see that the result of `TryLock` is used to branch.


I patched the proposed fix-forward and it seems to have things building again. Is there an ETA on landing that? If it's going to take a bit, is there any chance we could revert this patch until then?


Repository:
  rL LLVM

https://reviews.llvm.org/D52398





More information about the cfe-commits mailing list