[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

Victor Costan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 11:08:12 PDT 2018


pwnall accepted this revision.
pwnall added a comment.
This revision is now accepted and ready to land.

test/SemaCXX/warn-thread-safety-analysis.cpp LGTM -- this is the functionality that we need in Chrome to use thread safety annotations for AutoUnlock.

very non-authoritative opinion - I think the tests would be a bit easier to follow if Lock() would be the EXCLUSIVE_LOCK_FUNCTION and Unlock() would be the EXCLUSIVE_UNLOCK_FUNCTION.

aaronpuchert: Thank you for the patch! I'd be happy and grateful to have this functionality in Chrome.
delesley: Thank you for your review and guidance!


Repository:
  rC Clang

https://reviews.llvm.org/D52578





More information about the cfe-commits mailing list