[PATCH] D52891: [AMDGPU] Add -fvisibility-amdgpu-non-kernel-functions

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D52891#1256207, @arsenm wrote:

> I think the name needs work, but I'm not sure what it should be. I think it should avoid using "non" and "amdgpu"


I think dropping amdgpu is fine since we can add (AMDGUP only) to the description of the option, following the precedence of

  -ffixed-r9              Reserve the r9 register (ARM only)

However it is difficult to coin a different term for 'non-kernel-function'. Also, I saw precedence of using 'non' in option name:

  -objcmt-ns-nonatomic-iosonly

So, probably we could use `-fvisibility-nonkernel-function` ?


https://reviews.llvm.org/D52891