[PATCH] D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 5 10:11:14 PDT 2018
Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/readability/NumericalCostantsToMaxIntCheck.cpp:62
+ CompilerInstance &Compiler) {
+ if (this->getLangOpts().CPlusPlus) {
+ Compiler.getPreprocessor().addPPCallbacks(
----------------
JonasToth wrote:
> you dont need `this->` and please use the same return early pattern as in the other registering call
By the word, see PR32774 for such check suggestion.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52892
More information about the cfe-commits
mailing list