[PATCH] D52918: Emit CK_NoOp casts in C mode, not just C++.

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 08:05:52 PDT 2018


jyknight added a comment.

In https://reviews.llvm.org/D52918#1256420, @aaron.ballman wrote:

> Patch is missing tests -- perhaps you could dump the AST and check the casting notation from the output?


It would appear that which casts get emitted in C mode is almost completely untested. I added tests just for this change in a new file, and left a TODO to fill it out for the remainder of those functions.


https://reviews.llvm.org/D52918





More information about the cfe-commits mailing list